[Bug 1845] arm/rtl22xx_t fails to configure

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1845

--- Comment #1 from Ralf Corsepius <ralf.corsepius at rtems.org> 2011-07-22 06:25:08 CDT ---
This BSP's *.cfg on 4-10-branch is using an invalid syntax:

# cvs diff -u -r rtems-4-10-branch c/src/lib/libbsp/arm/rtl22xx/make/custom
cvs diff: Diffing c/src/lib/libbsp/arm/rtl22xx/make/custom
Index: c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg
===================================================================
RCS file:
/usr1/CVS/rtems/c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg    20 May 2010
13:00:41 -0000    1.2
+++ c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg    6 Dec 2010
23:13:11 -0000    1.3
@@ -3,7 +3,7 @@
 #
 #  $Id$
 #
-set USE_THUMB_MODE=YES
+USE_THUMB_MODE=YES

 #  This contains the compiler options necessary to select the CPU model
 #  and (hopefully) optimize for it. 



Apart of this, 
a) USE_THUMB_MODE is not used anywhere.
=> it is meaningless.

b) USE_THUMB_MODE violates the working principles of the *.cfgs.

c) This BSP had never been part of 4-9-branch
=> it should not be part of updates to 4.9.

# cvs diff -u -r rtems-4-9-branch c/src/lib/libbsp/arm/rtl22xx/make/custom
cvs diff: Diffing c/src/lib/libbsp/arm/rtl22xx/make/custom
cvs diff: tag rtems-4-9-branch is not in file
c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx.cfg
cvs diff: tag rtems-4-9-branch is not in file
c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.