[Bug 1861] RBTree: redundant code removed

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1861

--- Comment #4 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-07-29 10:54:28 CDT ---
(In reply to comment #3)
> Ok, the first one I would know if the function returned non-void. So you mean I
> can test for it with the RTEMS_DEBUG macro?

Use rtems_assert() if at all possible for cases like this.

> The second one I have tested the condition for each node in rbtree (size 1 -
> 100 nodes incrementally inserting nodes) to have only a left child which did
> not occur. It is always on the right if a node is single child.
> 
> The third one, I also have a test for trees of 1 - 100 nodes searching for
> condition where a dad and child are black and no other child is present. Not
> found. 
> But it is also just incremental insertion of nodes.

I am really not that familiar with the code.  I will have to trust you and
Gedare to make a judgement.  If the code is removed, there should definitely be
a comment added that explains why some check is missing.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.