[Bug 1788] SMP Thread CPU Usage Bookkeeping

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Wed May 11 20:02:11 UTC 2011


--- Comment #3 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-05-11 15:02:10 CDT ---
(In reply to comment #2)
> This patch changes the declarations of _Thread_Time_of_last_context_switch but
> does not replace its use, grepping through rtems I see something like:
> libmisc/cpuuse/cpuusagereport.c
> libmisc/cpuuse/cpuusagereset.c
> rtems/src/ratemonperiod.c
> score/src/threaddispatch.c

Some of those are deliberate. ratemonperiod.c and threaddispatch.c are updating
on the local CPU.

The cpuusage* cases were also deliberate but for a different reason.  We need a
PR filed so we don't forget to update them when we can test their SMP paths. 
It isn't functional enough to test them yet.  I filed 1793 to remind us of

> Also, I noticed that volatile bool dispatch_necessary; is declared, is the
> volatile necessary here?

Jennifer can comment on that.  I thought we had agreed to eliminate that. 
Maybe it is part of something she has pending.

Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the bugs mailing list