[Bug 1803] SMP: _Thread_Is_executing and _Thread_Is_heir

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1803

--- Comment #1 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-05-23 11:18:26 CDT ---
There is no reason to reimplement _Thread_Is_executing or _Thread_Is_heir for
SMP when the current CPU is implied.  That is already handled by macros for
_Thread_Executing and _Thread_Heir in percpu.h.  So these don't need to be part
of the patch.  

I have no problem adding the xxx_SMP ones with the second argument if the
following style changes are made:

+ parameter names should line up.
+ @param[in] should be used for each parameter
  - Yes.. missing on existing routines.  Fix this on yours and I will fix on
    other routines in thread.inl once your patch is committed.
+ @return should be used.
  - ditto on work for me.

That's it.  No issue technically on adding the xxx_SMP with 2 parameters.  But
the others are redundant.  So no need to touch them.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.