[Bug 1957] New: Unprotected macro arguments

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1957

           Summary: Unprotected macro arguments
           Product: RTEMS
           Version: HEAD
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: minor
          Priority: P3
         Component: cpukit
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: seb at tmplab.org


(from Werner Almesberger)

Index: coremutex.h
===================================================================
RCS file: /usr1/CVS/rtems/cpukit/score/include/rtems/score/coremutex.h,v
retrieving revision 1.45
diff -u -r1.45 coremutex.h
--- coremutex.h    2 Aug 2011 13:59:48 -0000    1.45
+++ coremutex.h    8 Nov 2011 23:13:01 -0000
@@ -395,8 +395,8 @@
            INTERNAL_ERROR_MUTEX_OBTAIN_FROM_BAD_STATE \
            ); \
     } \
-    if ( _CORE_mutex_Seize_interrupt_trylock( _the_mutex, &_level ) ) {  \
-      if ( !_wait ) { \
+    if ( _CORE_mutex_Seize_interrupt_trylock( _the_mutex, &(_level) ) ) {  \
+      if ( !(_wait) ) { \
         _ISR_Enable( _level ); \
         _Thread_Executing->Wait.return_code = \
           CORE_MUTEX_STATUS_UNSATISFIED_NOWAIT; \

Index: threadmp.inl
===================================================================
RCS file: /usr1/CVS/rtems/cpukit/score/inline/rtems/score/threadmp.inl,v
retrieving revision 1.19
diff -u -r1.19 threadmp.inl
--- threadmp.inl    5 Sep 2008 14:50:10 -0000    1.19
+++ threadmp.inl    8 Nov 2011 23:11:20 -0000
@@ -38,7 +38,7 @@
  *        _MPCI_Receive_server_tcb until it is used.
  */
 #define _Thread_MP_Is_receive(_the_thread) \
-  (_the_thread == _MPCI_Receive_server_tcb)
+  ((_the_thread) == _MPCI_Receive_server_tcb)

 /**
  *  This routine frees a proxy control block to the
_______________________________________________

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.