[Bug 1809] SMP : Lock/Unlock critical Section

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1809

Gedare <giddyup44 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giddyup44 at yahoo.com

--- Comment #1 from Gedare <giddyup44 at yahoo.com> 2011-10-27 19:15:30 CDT ---
I didn't comment on this before because the patch adds no useful implementation
that I can see. However, now that I see from the AMP that the macros are
basically rewrites for: 
ISR_Disable()
lock(bkl)
ISR_Enable()

Instead of using this _Lock_Critical_Section I think it would be better to see
something like
_SMP_lock_recursive_Obtain(&_SMP_Global_lock)

And similarly _SMP_lock_recursive_Release(&_SMP_Global_lock) for the
_Unlock_Critical_Section.

Then you will need to include a recursive lock implementation. (I believe the
spinlock_nested might be sufficient instead of introducing a new lock
implementation, but I have not enough information.)

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.