[Bug 1911] Include bsp.h in confdefs.h by default

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Mon Sep 12 07:58:56 UTC 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1911

--- Comment #4 from Sebastian Huber <sebastian.huber at embedded-brains.de> 2011-09-12 02:58:55 CDT ---
(In reply to comment #3)
> I do not like either proposals. What is the use case for this ?

The use case is #include <confdefs.h>.

> 
> I see confdefs.h as a means to configure RTEMS and not the BSP. The BSP has
> other hardware specific options which should not pollute confdefs.h.

The confdefs.h already depend on the BSP via the defines listed above.  This
means that

/* begin of file */
#include <confdefs.h>

may lead to something completely different than

/* begin of file */
#include <bsp.h>
#include <confdefs.h>

This is very bad.  It can confuse users and waste their time.

> 
> I see bsp.h as dangerous. It is useful to fix or paper over other issues that
> exist.

The primary issue is the usage of the listed defines.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list