[Bug 1906] CBS scheduler implementation

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Tue Sep 13 13:05:05 UTC 2011


--- Comment #7 from Petr Benes <benesp16 at fel.cvut.cz> 2011-09-13 08:05:05 CDT ---
(In reply to comment #5)
> Additional comments:
> 1. _Scheduler_CBS_Initialize: no check if _Workspace_Allocate fails
> 2. Same in _Scheduler_CBS_Create_server
> 3. _Scheduler_CBS_Detach_thread: NULL pointer dereference in the line
> sched_info = (Scheduler_CBS_Per_thread *) the_thread->scheduler_info;
> (the_thread may be NULL)
> 4. _Scheduler_CBS_Get_approved_budget: no check on approved_budget
> 5. In _Scheduler_CBS_Get_execution_time: can the_thread be NULL?
> 6. _Scheduler_CBS_Get_remaining_budget: can the_thread be NULL?
Thanks for finding these, I have fixed it and will update the patch as soon as
we resolve the signal/callback issue.
> 7. Usage of _Thread_Change_priority: are you sure it won't create recursion?
I think it should not happen, you probably mean that the
_Thread_Change_priority invokes _Scheduler_* functions. But the calls can not
create a live-locked loop.

Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the bugs mailing list