[Bug 1908] QoS library for CBS scheduler

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Mon Apr 23 13:12:02 UTC 2012


https://www.rtems.org/bugzilla/show_bug.cgi?id=1908

Gedare <gedare at rtems.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
         AssignedTo|joel.sherrill at oarcorp.com   |gedare at rtems.org

--- Comment #3 from Gedare <gedare at rtems.org> 2012-04-23 08:12:02 CDT ---
Created attachment 1468
  --> https://www.rtems.org/bugzilla/attachment.cgi?id=1468
consolidate libqos code and fix installed header location


The patch eliminates qreslib.inl, adds qreslib.h to the cpukit/Makefile.am, and
installs qreslib.h under $(includedir)/rtems.

This patch addresses the following complaints raised during post-commit review:
* cpukit/libqos/preinstall.am is missing
* cpukit/libqos/qreslib.inl doesn't make sense. It is unconditionally included
by qreslib.h
* qreslib.h and qreslib.inl are installed into $(includedir). All RTEMS
specific headers are supposed to be installed into $(includedir)/rtems.
* qreslib.inl lacks header guards. It is not safe against multiple inclusion.
* qreslib.inl is installed into $(includedir). We have a convention to install
*.inl's into inline subdirectories.
* introducing a libqos/ subdirectory might not be good

The libqos subdirectory remains for now although it only contains one header
file so we could consider moving that header somewhere else quite easily
enough.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list