[Bug 2014] GRETH: added support for non-snooping GRETH 10/100 systems

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Wed Mar 21 17:00:26 UTC 2012


https://www.rtems.org/bugzilla/show_bug.cgi?id=2014

--- Comment #5 from Gedare <gedare at rtems.org> 2012-03-21 12:00:26 CDT ---
(In reply to comment #4)
> Hello,
> 
> I can see your concern about being LEON specific. I think that it has always
> been SPARC-specific due to the usage of set_vec(). However my last GRETH patch
> (not yet submitted) will change from set_vec() to
> rtems_interrupt_handler_install() and one patch will implement the generic
> shared-irq layer on the LEON BSPs.
> 
> I can update this patch:
>  1. Instead of NO_CACHE_LOAD(), let bsp.h define GRETH_DMA_LOAD()
>  2. GRETH_SUPPORTED is defined by bsp.h instead of in greth.c. Similar to the
> "SMC91111: ERC32 eas never supported by driver" patch.
> 
This would be better as it would get rid of the assembly in the driver.

> This way it can remain independent of LEON and SPARC.
> 
> What do you think?
> 
> Otherwise I fine with the move, even though many drivers in libchip/network
> seems to be sort of BSP/platform specific I think that we should aim to make
> the drivers as platform independent as possible.
> 
> Daniel

Can greth reasonably be used by non-sparc systems? If so it should remain in
libchip and changes should be made to make it more generic as you suggested. If
not it should probably go into the sparc libbsp (or libcpu) subdirectories.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list