[Bug 2137] New: rtems_rfs_rtems_initialise() prototype differs from implementation and rtems_filesystem_fsmount_me_t (missing void* data parameter), causes compile-time warning

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=2137

             Bug #: 2137
           Summary: rtems_rfs_rtems_initialise() prototype differs from
                    implementation and rtems_filesystem_fsmount_me_t
                    (missing void* data parameter), causes compile-time
                    warning
    Classification: Unclassified
           Product: RTEMS
           Version: HEAD
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: cpukit
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: nick.withers at anu.edu.au


Created attachment 1515
  --> https://www.rtems.org/bugzilla/attachment.cgi?id=1515
Patch adding "const void* data" parameter to rtems_rfs_rtems_initialize()'s
declaration, matching its definition

The rtems_rfs_rtems_initialise() prototype in rtems-rfs.h states that the
function takes only an rtems_filesystem_mount_table_entry_t parameter, and not
a "const void *data", per its implementation and rtems_filesystem_fsmount_me_t.

This causes a warning to be generated when CONFIGURE_FILESYSTEM_RFS is defined
as a (by default) "{ RTEMS_FILESYSTEM_TYPE_RFS, rtems_rfs_rtems_initialise }"
entry is added to rtems_filesystem_table_t rtems_filesystem_table in
confdefs.h, where the second argument should be a function pointer of
rtems_filesystem_fsmount_me_t type, e.g.:
____

powerpc-rtems4.11-gcc --pipe -std=c99 -g -Wall -Wpointer-arith -mcpu=powerpc
-msoft-float -D__ppc_generic -I.
-I/home/nick/rtems/rtems-4.11/powerpc-rtems4.11/mvme3100/lib/include
-I/home/nick/rtems/RTEMS_gdb_stub_1_5 -O0 -DDEBUG=1 -DDEBUG_GDB_STUB=1
-DDEBUG_INIT_DONE_RESET=0 -DDEBUG_HALT_ON_FATAL=0
-DSINGLES_SPECTRUM_LITTLE_ENDIAN -c -o init.o init.c
In file included from init.h:88:0,
                 from init.c:23:
/home/nick/rtems/rtems-4.11/powerpc-rtems4.11/mvme3100/lib/include/rtems/confdefs.h:514:9:
warning: initialization from incompatible pointer type [enabled by default]
         CONFIGURE_FILESYSTEM_ENTRY_RFS,
         ^
____

The attached patch adds the "const void* data" parameter to the header
declaration.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.