[RTEMS Project] #1518: Bdbuf IO request cleanup

RTEMS trac trac at rtems.org
Wed Dec 17 07:26:39 UTC 2014


#1518: Bdbuf IO request cleanup
-----------------------------+----------------------------
 Reporter:  sebastian.huber  |       Owner:  joel.sherrill
     Type:  defect           |      Status:  new
 Priority:  low              |   Milestone:  5.0
Component:  cpukit           |     Version:  4.10
 Severity:  minor            |  Resolution:
 Keywords:                   |
-----------------------------+----------------------------
Changes (by sebastian.huber):

 * priority:  normal => low
 * severity:  normal => minor
 * milestone:  4.11 => 5.0


Old description:

> Reported by Chris Johns in Bug 1433:
>
> We need to remove the SG alloc calls from the cache read code. The code
> currently allocates a block of RAM on the stack with an array of pointers
> to
> the BD. I consider the array of size of 1 at the end of the struct and
> the way
> it is allocated as fragile code. The BD already contain a link node which
> is
> not used at the driver layer. It would be much better to use a chain to
> hold a
> list of BDs to fill.

New description:

 Reported by Chris Johns in Bug 1433:

 We need to remove the SG alloc calls from the cache read code. The code
 currently allocates a block of RAM on the stack with an array of pointers
 to
 the BD. I consider the array of size of 1 at the end of the struct and the
 way
 it is allocated as fragile code. The BD already contain a link node which
 is
 not used at the driver layer. It would be much better to use a chain to
 hold a
 list of BDs to fill.

--

--
Ticket URL: <http://devel.rtems.org/ticket/1518#comment:5>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list