[RTEMS Project] #1459: Make Monitor Commands first class citizens in shell, (was: Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?)

RTEMS trac trac at rtems.org
Sun Nov 23 17:37:06 UTC 2014


#1459: Make Monitor Commands first class citizens in shell,
----------------------------+-----------------------
 Reporter:  ralf.corsepius  |       Owner:  chrisj
     Type:  defect          |      Status:  assigned
 Priority:  normal          |   Milestone:  5.0
Component:  shell           |     Version:  4.10
 Severity:  minor           |  Resolution:
 Keywords:                  |
----------------------------+-----------------------
Changes (by joel.sherrill):

 * milestone:  4.11 => 5.0


Old description:

> rtems_shell_main_monitor
> is a private function of
> cpukit/libmisc/shell/cmds.c
>
> However, the way
> testsuites/libtests/monitor02/init.c
> uses it (as a public/exported function) to me reads as a strong
> indication that
> rtems_shell_main_monitor()
> should be "made public" by declaring/prototyping it in
> cpukit/libmisc/shell/shell.h

New description:

 rtems_shell_main_monitor
 is a private function of
 cpukit/libmisc/shell/cmds.c

 However, the way
 testsuites/libtests/monitor02/init.c
 uses it (as a public/exported function) to me reads as a strong indication
 that
 rtems_shell_main_monitor()
 should be "made public" by declaring/prototyping it in
 cpukit/libmisc/shell/shell.h

--

Comment:

 The monitor predates the shell. There is really no point in having two
 CLIs. The monitor commands are available in the shell but the integration
 is a hack. The monitor commands need to be made first class shell commands
 and the set for looking at objects enhanced to include more objects.

 This may be a decent GSoC project.

--
Ticket URL: <http://devel.rtems.org/ticket/1459#comment:4>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list