[RTEMS Project] #2113: sparc/leon2 - incorrect include for <ringbuf.h>

[RTEMS trac]

#2113: sparc/leon2 - incorrect include for <ringbuf.h>
---------------------------+----------------------------
 Reporter:  joel.sherrill  |       Owner:  joel.sherrill
     Type:  defect         |      Status:  new
 Priority:  normal         |   Milestone:  4.11
Component:  bsps           |     Version:  4.11
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+----------------------------
Changes (by joel.sherrill):

 * version:  unknown => 4.11


Old description:

> Reported http://www.rtems.org/pipermail/rtems-
> users/2013-April/011253.html
>
> Likely to impact older versions so filing a tracking PR. The code needs
> to change from <ringbuf.h> to <rtems/ringbuf.h>.
>
> I believe there may be a problem with the bsp code for leon2 bsp.  When
> configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result
> in
> a file not found error for 'ringbuf.h' for the compile of the file
> 'c/src/lib/libbsp/sparc/leon2/console/console.c'.
>

> b-leon2 Config:
> ../rtems-4.11/configure --target=sparc-rtems \
> --enable-rtemsbsp=leon2 \
> --prefix=<rtems-install> --enable-posix \
> CONSOLE_USE_INTERRUPTS=1
>
> To work around the issue I revised 'console.c ' line 73 from
>
> #include <ringbuf.h>
>
> To
>
> #include <rtems/ringbuf.h>

New description:

 Reported http://www.rtems.org/pipermail/rtems-users/2013-April/011253.html

 Likely to impact older versions so filing a tracking PR. The code needs to
 change from <ringbuf.h> to <rtems/ringbuf.h>.

 I believe there may be a problem with the bsp code for leon2 bsp.  When
 configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result
 in
 a file not found error for 'ringbuf.h' for the compile of the file
 'c/src/lib/libbsp/sparc/leon2/console/console.c'.


 b-leon2 Config:
 ../rtems-4.11/configure --target=sparc-rtems \
 --enable-rtemsbsp=leon2 \
 --prefix=<rtems-install> --enable-posix \
 CONSOLE_USE_INTERRUPTS=1

 To work around the issue I revised 'console.c ' line 73 from

 #include <ringbuf.h>

 To

 #include <rtems/ringbuf.h>

--

Comment:

 <ringbuf.h> was moved to <rtems/ringbug.h> in 2011 and apparently the
 person who made the change didn't run grep.

--
Ticket URL: <http://devel.rtems.org/ticket/2113#comment:2>
RTEMS Project <http://www.rtems.org/>
RTEMS Project