[RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

RTEMS trac trac at rtems.org
Tue Apr 28 08:18:09 UTC 2015


#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
---------------------+-----------------------
 Reporter:  dcb      |       Owner:  daniel
     Type:  defect   |      Status:  assigned
 Priority:  normal   |   Milestone:  4.11.1
Component:  General  |     Version:  4.10
 Severity:  normal   |  Resolution:
 Keywords:           |
---------------------+-----------------------

Comment (by daniel):

 case 1 is a memory leak. It should be safe for the driver to assume that
 dev->businfo always is initialized, setting it to NULL makes no sense when
 a device have been created. Rather it should check if the APB registers
 are present.

 case 2. is ok as Joel points out.

 The driver does not implement the drvmgr device remove() function, so the
 memory is never freed.

 I will suggest a pacth.

--
Ticket URL: <http://devel.rtems.org/ticket/2331#comment:3>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list