[RTEMS Project] #2700: cpukit/libfs/src/nfsclient/src/rpcio.c:524]: (style) Suspicious condition

RTEMS trac trac at rtems.org
Tue Apr 26 09:38:34 UTC 2016


#2700: cpukit/libfs/src/nfsclient/src/rpcio.c:524]: (style) Suspicious condition
---------------------+--------------------
 Reporter:  dcb      |      Owner:
     Type:  defect   |     Status:  new
 Priority:  normal   |  Milestone:  4.11.1
Component:  General  |    Version:  4.10
 Severity:  normal   |   Keywords:
---------------------+--------------------
 cpukit/libfs/src/nfsclient/src/rpcio.c:524]: (style) Suspicious condition
 (assignment + comparison); Clarify expression with parentheses.

 Source code is

    if ( (len = getgroups(NGROUPS, gids) < 0 ) ) {

 maybe better code

    if ( (len = getgroups(NGROUPS, gids)) < 0 ) {

--
Ticket URL: <http://devel.rtems.org/ticket/2700>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list