[RTEMS Project] #2766: /src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891: code and comment don't match ?

RTEMS trac trac at rtems.org
Mon Jul 25 15:54:29 UTC 2016


#2766: /src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891:
code and comment don't match ?
---------------------+--------------------
 Reporter:  dcb      |      Owner:
     Type:  defect   |     Status:  new
 Priority:  normal   |  Milestone:  4.11.1
Component:  General  |    Version:  4.10
 Severity:  normal   |   Keywords:
---------------------+--------------------
 rtems/c/src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891]:
 (style) Same expression on both sides of '|'

 Source code is

     /* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
     __HAL_FMPI2C_DISABLE_IT(hfmpi2c,FMPI2C_IT_ERRI | FMPI2C_IT_TCI|
 FMPI2C_IT_STOPI| FMPI2C_IT_NACKI | FMPI2C_IT_ADDRI | FMPI2C_IT_RXI |
 FMPI2C_IT_RXI );

 Maybe better code

     /* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
     __HAL_FMPI2C_DISABLE_IT(hfmpi2c,FMPI2C_IT_ERRI | FMPI2C_IT_TCI|
 FMPI2C_IT_STOPI| FMPI2C_IT_NACKI | FMPI2C_IT_ADDRI | FMPI2C_IT_RXI |
 FMPI2C_IT_TXI );

--
Ticket URL: <http://devel.rtems.org/ticket/2766>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list