[RTEMS Project] #2678: possible unnecessary includes in console drivers

[RTEMS trac]

#2678: possible unnecessary includes in console drivers
---------------------------+----------------------------
 Reporter:  joel.sherrill  |       Owner:  joel.sherrill
     Type:  enhancement    |      Status:  new
 Priority:  low            |   Milestone:  4.12
Component:  bsps           |     Version:  4.12
 Severity:  minor          |  Resolution:
 Keywords:                 |
---------------------------+----------------------------
Description changed by joel.sherrill:

Old description:

> I am making a sweep to eliminate the include of <rtems/console.h> from
> <bsp.h>. This involves adding it to a few console drivers. I am seeing
> includes of multiple files that I am suspicious are not needed or should
> be corrected:
>
> * <malloc.h>
> * <rtems/mw_uid.h>
> * <fcntl.h>
> * use of <assert.h>
> * <stdio.h>
> * some comments that <bsp.h> must be included before <rtems/libio.h>
>
> I reordering in some to try a pattern of include files as follows:
>
> * standard C/POSIX .h files
> * standard RTEMS files without <rtems.h> as first
> * <bsp.h>
> * private .h files
>
> This may not work but could be part of the remove rtems/console.h from
> bsp.h patch series.
>
> I will not be able to investigate immediately so am filing a ticket for
> future follow up.

New description:

 I am making a sweep to eliminate the include of <rtems/console.h> from
 <bsp.h>. This involves adding it to a few console drivers. I am seeing
 includes of multiple files that I am suspicious are not needed or should
 be corrected:

 * <malloc.h>
 * ~~<rtems/mw_uid.h>~~
 * <fcntl.h>
 * use of <assert.h> - there are 100s of asserts. This is beyond my current
 activities.
 * <stdio.h>
 * some comments that <bsp.h> must be included before <rtems/libio.h>

 I reordering in some to try a pattern of include files as follows:

 * standard C/POSIX .h files
 * standard RTEMS files without <rtems.h> as first
 * <bsp.h>
 * private .h files

 This may not work but could be part of the remove rtems/console.h from
 bsp.h patch series.

 I will not be able to investigate immediately so am filing a ticket for
 future follow up.

--

--
Ticket URL: <http://devel.rtems.org/ticket/2678#comment:2>
RTEMS Project <http://www.rtems.org/>
RTEMS Project