[RTEMS Project] #2876: src/c/src/lib/libbsp/shared/gpio.c:251: broken error checking ?

RTEMS trac trac at rtems.org
Thu Jan 19 21:03:34 UTC 2017


#2876: src/c/src/lib/libbsp/shared/gpio.c:251: broken error checking ?
---------------------+------------------
 Reporter:  dcb      |      Owner:
     Type:  defect   |     Status:  new
 Priority:  normal   |  Milestone:  4.12
Component:  General  |    Version:  4.11
 Severity:  normal   |   Keywords:
---------------------+------------------
 src/c/src/lib/libbsp/shared/gpio.c:251]: (style) Checking if unsigned
 variable 'rv' is less than zero.

 Source code is

         rv = debounce_switch(interrupt_state);

         /* If the handler call was caused by a switch bounce,
          * ignores and move on. */
         if ( rv < 0 ) {

 but

 static int debounce_switch(gpio_pin_interrupt_state *interrupt_state)

 and

   uint8_t rv;

--
Ticket URL: <http://devel.rtems.org/ticket/2876>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list