[RTEMS Project] #3010: src/cpukit/posix/src/mmap.c:189]: (style) Suspicious condition

RTEMS trac trac at rtems.org
Mon May 8 19:33:43 UTC 2017


#3010: src/cpukit/posix/src/mmap.c:189]: (style) Suspicious condition
-----------------------------+--------------------
 Reporter:  David Binderman  |      Owner:  (none)
     Type:  defect           |     Status:  new
 Priority:  normal           |  Milestone:  4.12
Component:  General          |    Version:  4.12
 Severity:  normal           |   Keywords:
-----------------------------+--------------------
 src/cpukit/posix/src/mmap.c:189]: (style) Suspicious condition (bitwise
 operator + comparison); Clarify expression with parentheses.

 Source code is

   } else if ( (flags & MAP_PRIVATE != MAP_PRIVATE) ) {

 Maybe better code

   } else if ( (flags & MAP_PRIVATE) != MAP_PRIVATE ) {

--
Ticket URL: <http://devel.rtems.org/ticket/3010>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list