[RTEMS Project] #3016: missing a couple register names + a #ifndef __ASM__ around serial.h inclusion

RTEMS trac trac at rtems.org
Wed May 17 16:15:26 UTC 2017


#3016: missing a couple register names + a #ifndef __ASM__ around serial.h
inclusion
--------------------------+------------------------------
 Reporter:  phongvanpham  |       Owner:  joel.sherrill@…
     Type:  defect        |      Status:  closed
 Priority:  normal        |   Milestone:  4.12.0
Component:  bsps          |     Version:  4.12
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |
--------------------------+------------------------------

Comment (by phongvanpham):

 Replying to [comment:2 Sebastian Huber]:
 > Please generate the Git patch with your real name and a valid e-mail
 address.
 >
 > This ns16550_p.h is a private header file, why do you have to change it?

 The changes are b/c a couple of register names are missing.  Yes one can
 use another name with the intended value; however, this is unmaintainable
 code.  As you can see, there are different names of the same value
 (register number) in the file.

 The reason to use #ifndef here is b/c I intend to use the file elsewhere
 in my BSP.  Basically, I cherry pick code to maximize reuse in order to
 meet my needs.  If you object to this particular change, (thus my needs
 are not met,) I will copy the file to my BSP to resolve my problem; thus a
 lack of sharing/reusing.

--
Ticket URL: <http://devel.rtems.org/ticket/3016#comment:4>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list