[RTEMS Project] #3405: src/bsps/sparc/shared/tmtc/grtc.c:1871]: (style) Suspicious condition

[RTEMS trac]

#3405: src/bsps/sparc/shared/tmtc/grtc.c:1871]: (style) Suspicious condition
------------------------------+--------------------
  Reporter:  David Binderman  |      Owner:  (none)
      Type:  defect           |     Status:  new
  Priority:  normal           |  Milestone:
 Component:  admin            |    Version:
  Severity:  normal           |   Keywords:
Blocked By:                   |   Blocking:
------------------------------+--------------------
 src/bsps/sparc/shared/tmtc/grtc.c:1871]: (style) Suspicious condition
 (assignment + comparison); Clarify expression with parentheses.

 Source code is

                while ( pDev->running && ((ret=process_dma(pDev) == 2) ||
 (ret == -1)) ) {

 Maybe better code

                while ( pDev->running && (((ret = process_dma(pDev)) == 2)
 || (ret == -1)) ) {

--
Ticket URL: <http://devel.rtems.org/ticket/3405>
RTEMS Project <http://www.rtems.org/>
RTEMS Project