[RTEMS Project] #2577: Complete per-function section addition sweep

RTEMS trac trac at rtems.org
Fri Nov 30 20:14:04 UTC 2018


#2577: Complete per-function section addition sweep
---------------------------+----------------------------
 Reporter:  Joel Sherrill  |       Owner:  Joel Sherrill
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:  Indefinite
Component:  bsps           |     Version:  5
 Severity:  normal         |  Resolution:  fixed
 Keywords:                 |  Blocked By:
 Blocking:                 |
---------------------------+----------------------------
Changes (by Joel Sherrill):

 * status:  assigned => closed
 * resolution:   => fixed


Old description:

> As part of the GCI task described at
> https://devel.rtems.org/wiki/GCI/Coding/AddPerSectionSupportToBSPs, most
> BSPs were reviewed for the addition of per function section compilation
> and linking. This ticket is to complete that sweep.
>
> Use #2572 as a guide for the new ticket. Just copy the contents and
> change the title to reflect the different BSP. Use the commented out
> lines for the mcf5206elite BSP make/custom file as a guide.  Short
> version:
>
> * Do the GCI task for each BSP family listed below. Follow the format for
> the commit message.
>
> * If the BSP has KEEP sections and cxx_iostream does not drop a
> suspiciously large amount, then the modification should be OK to be
> merged.
>
> * If the BSP does NOT have KEEP sections, then a BSP specific ticket
> should be filed and the per-function section build lines commented out in
> the .cfg file with a FIXME line and the ticket number.
>
> * When done, update the associated ticket for the BSP family as needed.
> It should be closed as a side-effect of commiting any fixes so do NOT
> manually close them.
>
> Follow the instructions in that GCI task with the addition that you
> should be EXTREMELY cautious in reviewing the size drop and whether the
> BSP linker script has KEEP sections. If the BSP does not have KEEP
> sections file a ticket to track it.
>
> Be very careful to follow the existing patterns for tickets, commit
> messages, and code changes such as #2579 for the
> powerpc/motorola_powerpc. At the bottom of this text is a current list of
> "BSP families" which an automated search shows as missing per-function
> section linking.
>
> Some of these may already be implemented and just need to be reviewed and
> closed. Close this ticket when they are all done
>
> The following tickets are for BSPs which still need per function
> sections:
>
> [[TicketQuery(status=accepted|assigned|new|reopened,
> keywords=~KEEP|~function+sections,order=priority)]]
>
> The full set of BSPs impacted by this ticket is:
>
> [[TicketQuery(keywords=~KEEP|~function+sections,order=priority)]]

New description:

 As part of the GCI task described at
 https://devel.rtems.org/wiki/GCI/Coding/AddPerSectionSupportToBSPs, most
 BSPs were reviewed for the addition of per function section compilation
 and linking. This ticket is to complete that sweep.

 Use #2572 as a guide for the new ticket. Just copy the contents and change
 the title to reflect the different BSP. Use the commented out lines for
 the mcf5206elite BSP make/custom file as a guide.  Short version:

 * Do the GCI task for each BSP family listed below. Follow the format for
 the commit message.

 * If the BSP has KEEP sections and cxx_iostream does not drop a
 suspiciously large amount, then the modification should be OK to be
 merged.

 * If the BSP does NOT have KEEP sections, then a BSP specific ticket
 should be filed and the per-function section build lines commented out in
 the .cfg file with a FIXME line and the ticket number.

 * When done, update the associated ticket for the BSP family as needed. It
 should be closed as a side-effect of commiting any fixes so do NOT
 manually close them.

 Follow the instructions in that GCI task with the addition that you should
 be EXTREMELY cautious in reviewing the size drop and whether the BSP
 linker script has KEEP sections. If the BSP does not have KEEP sections
 file a ticket to track it.

 Be very careful to follow the existing patterns for tickets, commit
 messages, and code changes such as #2579 for the powerpc/motorola_powerpc.
 At the bottom of this text is a current list of "BSP families" which an
 automated search shows as missing per-function section linking.

 Some of these may already be implemented and just need to be reviewed and
 closed. Close this ticket when they are all done

 The following tickets are for BSPs which still need per function sections:

 [[TicketQuery(status=accepted|assigned|new|reopened,
 keywords=~KEEP|~function+sections,order=priority)]]

 NONE

 The full set of BSPs impacted by this ticket is:

 [[TicketQuery(keywords=~KEEP|~function+sections,order=priority)]]

--

--
Ticket URL: <http://devel.rtems.org/ticket/2577#comment:13>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list