[RTEMS Project] #3573: DHCP request includes host name option even if hostname is zero length

[RTEMS trac]

#3573: DHCP request includes host name option even if hostname is zero length
---------------------+---------------------------
  Reporter:  Sal     |      Owner:  (none)
      Type:  defect  |     Status:  new
  Priority:  normal  |  Milestone:
 Component:  admin   |    Version:  4.11
  Severity:  normal  |   Keywords:  DHCP hostname
Blocked By:          |   Blocking:
---------------------+---------------------------
 DHCP requests add the hostname option in dhcp_request_req() without
 checking its length, so the hostname can be of any length. This is a
 defect because the DHCP spec (​https://tools.ietf.org/html/rfc2132)
 requires the hostname to have a minimum length of 1 char.
 This appears to trigger a bug in a specific Netgear router that causes
 it's DHCP process to lock up and could affect other things as well.

 This bug can be solved applying the patch made by Aun-Ali Zaidi in the
 original ticket reporting this defect
 (​https://devel.rtems.org/ticket/1405) that was never applied. I've also
 attached the patch in this ticket.
 I've been able to compile the code with the patch applied and it didn't
 raise any warnings.

 Original ticket: ​https://devel.rtems.org/ticket/1405

--
Ticket URL: <http://devel.rtems.org/ticket/3573>
RTEMS Project <http://www.rtems.org/>
RTEMS Project