[RTEMS Project] #4237: consolesimpletask.c: Two Unchecked Return Values (CID #1437625 and #1472765) (was: consolesimpletask.c: Unchecked Return Value (CID #1437625))

[RTEMS trac]

#4237: consolesimpletask.c: Two Unchecked Return Values (CID #1437625 and
#1472765)
-----------------------+---------------------
 Reporter:  Ryan Long  |       Owner:  (none)
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  6.1
Component:  lib        |     Version:  6
 Severity:  normal     |  Resolution:
 Keywords:             |  Blocked By:
 Blocking:             |
-----------------------+---------------------
Description changed by Joel Sherrill:

Old description:

> CID 1437625 (#1 of 1): Unchecked return value from call to
> rtems_task_create().
>
> Snippet from Coverity output.
>
> {{{
> 234  IMFS_add_node( "/dev", &cons->Node, NULL );
> 235
>
> CID 1437625 (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 1. check_return: Calling rtems_task_create without checking return value
> (as is done elsewhere 22 out of 25 times).
> 236  rtems_task_create(
> 237    rtems_build_name('C', 'O', 'N', 'S'),
> 238    RTEMS_MAXIMUM_PRIORITY - 1,
> 239    RTEMS_MINIMUM_STACK_SIZE,
> 240    RTEMS_DEFAULT_ATTRIBUTES,
> 241    RTEMS_DEFAULT_MODES,
> 242    &cons->task
> 243  );
> 244
> }}}

New description:

 CID 1437625: Unchecked return value from call to rtems_task_create().
 CID 1472765: Unchecked return value from call to rtems_task_start().

 Snippet from Coverity output.

 {{{
 234  IMFS_add_node( "/dev", &cons->Node, NULL );
 235

 CID 1437625 (#1 of 1): Unchecked return value (CHECKED_RETURN)
 1. check_return: Calling rtems_task_create without checking return value
 (as is done elsewhere 22 out of 25 times).
 236  rtems_task_create(
 237    rtems_build_name('C', 'O', 'N', 'S'),
 238    RTEMS_MAXIMUM_PRIORITY - 1,
 239    RTEMS_MINIMUM_STACK_SIZE,
 240    RTEMS_DEFAULT_ATTRIBUTES,
 241    RTEMS_DEFAULT_MODES,
 242    &cons->task
 243  );
 244
         CID 1472765: Unchecked return value (CHECKED_RETURN) [select
 issue]
 245  rtems_task_start(
 246    cons->task,
 247    _Console_simple_task_Task,
 248    (rtems_task_argument) cons
 249  );
 250}
 }}}

--

--
Ticket URL: <http://devel.rtems.org/ticket/4237#comment:2>
RTEMS Project <http://www.rtems.org/>
RTEMS Project