[RTEMS Project] #4240: rtems-debugger-target.c: Dereference before null check spotted by Coverity

[RTEMS trac]

#4240: rtems-debugger-target.c: Dereference before null check spotted by Coverity
---------------------------+-------------------------
  Reporter:  Ryan Long     |      Owner:  Chris Johns
      Type:  defect        |     Status:  new
  Priority:  normal        |  Milestone:  6.1
 Component:  lib/debugger  |    Version:  6
  Severity:  normal        |   Keywords:
Blocked By:                |   Blocking:
---------------------------+-------------------------
 CID 1468682: swbreaks is assigned a value dereferenced from target before
 it has been verified that target is not null.

 {{{
 173  rtems_debugger_target*         target = rtems_debugger->target;
    deref_ptr: Directly dereferencing pointer target.
 174  rtems_debugger_target_swbreak* swbreaks = target->swbreaks.block;
 175  size_t                         swbreak_size;
 176  uint8_t*                       loc = (void*) addr;
 177  size_t                         i;
 178  int                            r;
 179
    CID 1468682 (#1 of 1): Dereference before null check
 (REVERSE_INULL)check_after_deref: Null-checking target suggests that it
 may be null, but it has already been dereferenced on all paths leading to
 the check.
 180  if (target == NULL || swbreaks == NULL || kind !=
 target->breakpoint_size) {
 181    errno = EIO;
 182    return -1;
 183  }
 }}}

--
Ticket URL: <http://devel.rtems.org/ticket/4240>
RTEMS Project <http://www.rtems.org/>
RTEMS Project