[RTEMS Project] #4406: rtems: Constify rtems_task_wake_when()

RTEMS trac trac at rtems.org
Wed May 12 19:27:04 UTC 2021

#4406: rtems: Constify rtems_task_wake_when()
 Reporter:  Sebastian Huber  |       Owner:  Sebastian Huber
     Type:  enhancement      |      Status:  closed
 Priority:  normal           |   Milestone:  6.1
Component:  rtems            |     Version:  6
 Severity:  normal           |  Resolution:  fixed
 Keywords:                   |  Blocked By:
 Blocking:                   |
Changes (by Sebastian Huber <sebastian.huber@…>):

 * status:  assigned => closed
 * resolution:   => fixed


 In [changeset:"523867de9d274d2bdc29ce649d764b42a9167c0e/rtems"
 #!CommitTicketReference repository="rtems"
 rtems: Constify rtems_task_wake_when()

 Add a parameter to _TOD_Validate() to disable the validation of the
 ticks member.

 There are two reasons for this change.  Firstly, in
 rtems_task_wake_when() was a double check for time_buffer == NULL (one
 in rtems_task_wake_when() and one in _TOD_Validate()).  Secondly, the
 ticks member is ignored by rtems_task_wake_when().  This was done with a
 write of zero to the ticks member and thus a modification of the
 user-provided structure.  Now the structure is no longer modified.
 Using a mask parameter is quite efficient. You just have to load an
 immediate value and there are no additional branches in _TOD_Validate().

 Close #4406.

Ticket URL: <http://devel.rtems.org/ticket/4406#comment:1>
RTEMS Project <http://www.rtems.org/>
RTEMS Project

More information about the bugs mailing list