[RTEMS Project] #2348: Timecounter: Add NTP support

RTEMS trac trac at rtems.org
Thu Oct 28 22:57:18 UTC 2021


#2348: Timecounter: Add NTP support
-----------------------------+-------------------------
 Reporter:  Sebastian Huber  |       Owner:  (none)
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Indefinite
Component:  score            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |  Blocked By:
 Blocking:                   |
-----------------------------+-------------------------

Comment (by Chris Johns):

 Replying to [comment:9 Sebastian Huber]:
 > Replying to [comment:8 Chris Johns]:
 > > Replying to [comment:6 Sebastian Huber]:
 > > > Replying to [comment:4 Chris Johns]:
 > > > > Replying to [comment:3 Sebastian Huber]:
 > > > > > The kern_tc.c is quite close to the original FreeBSD code and
 the Doxygen comment block on top of the file is not an issue.
 > > > >
 > > > > Why the special exception here?
 > > > >
 > > > > My focus for the leadership group, including you, is to set
 policies for this sort of thing and then having everyone accept and adhere
 to them. It is simpler and more democratic to do this. My concern is
 having a rule that creates an exceptions because it makes things
 complicated. I know this is a single file but there are other places where
 more code comes across and this is where things become confusing.
 > > >
 > > > There is not just one rule involved here. The timekeeping is an
 important service of an operating system. It should be visible in the
 internal documentation (Doxygen). The file history shows that there is no
 issue with keeping it in synchronization with FreeBSD.
 > >
 > > This is not about the history. The history of this file reflects the
 quality of the person currently doing the work and it is a very high
 standard. Expecting that standard everywhere is asking a lot. I think we
 need to document how we integrate external code and for that I was
 considering the following as the basis:
 > >
 > > https://git.rtems.org/rtems-libbsd/tree/CONTRIBUTING.md#n248
 > >
 > > I would be interested to understand how this `score` file or files
 like it could be handled by a rule or rules? A rule in the ticket may not
 be clean and suitable documentation however it provides me with a means to
 show what we consider as OK if you could provide this.
 >
 > The libbsd contributing rules make sense for libbsd which deals with a
 couple of hundred files and a semi-automatic synchronization support.
 >
 > External files placed in the score should integrate into the score
 documentation and be maintainable. Here we need a bit more flexibility.

 This makes sense. Should the documentation should be limited to a single
 block at the start of the file and else where in the file the LibBSD rules
 apply?

--
Ticket URL: <http://devel.rtems.org/ticket/2348#comment:12>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list