[RTEMS Project] #1459: Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?

RTEMS trac trac at rtems.org
Tue Nov 29 21:49:38 UTC 2022


#1459: Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?
----------------------------+--------------------------
 Reporter:  Ralf Corsepius  |       Owner:  Chris Johns
     Type:  defect          |      Status:  closed
 Priority:  normal          |   Milestone:  6.1
Component:  shell           |     Version:  4.10
 Severity:  minor           |  Resolution:  fixed
 Keywords:                  |  Blocked By:
 Blocking:                  |
----------------------------+--------------------------
Changes (by Chris Johns):

 * status:  assigned => closed
 * resolution:   => fixed


Old description:

> rtems_shell_main_monitor
> is a private function of
> cpukit/libmisc/shell/cmds.c
>
> However, the way
> testsuites/libtests/monitor02/init.c
> uses it (as a public/exported function) to me reads as a strong
> indication that
> rtems_shell_main_monitor()
> should be "made public" by declaring/prototyping it in
> cpukit/libmisc/shell/shell.h

New description:

 rtems_shell_main_monitor
 is a private function of
 cpukit/libmisc/shell/cmds.c

 However, the way
 testsuites/libtests/monitor02/init.c
 uses it (as a public/exported function) to me reads as a strong indication
 that
 rtems_shell_main_monitor()
 should be "made public" by declaring/prototyping it in
 cpukit/libmisc/shell/shell.h

--

Comment:

 Fixed in 2011.

--
Ticket URL: <http://devel.rtems.org/ticket/1459#comment:6>
RTEMS Project <http://www.rtems.org/>
RTEMS Project


More information about the bugs mailing list