RTEMS | amd64: Restructure the APIC code (!168)

Tue Aug 6 23:39:53 UTC 2024

Kinsey Moore started a new discussion on bsps/x86_64/amd64/include/apic.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/168#note_110604

 > -#define APIC_REGISTER_EOI           APIC_OFFSET(0x0B0)
 > -#define APIC_REGISTER_SPURIOUS      APIC_OFFSET(0x0F0)
 > -#define APIC_REGISTER_LVT_TIMER     APIC_OFFSET(0x320)
 > -#define APIC_REGISTER_TIMER_INITCNT APIC_OFFSET(0x380)
 > -#define APIC_REGISTER_TIMER_CURRCNT APIC_OFFSET(0x390)
 > -#define APIC_REGISTER_TIMER_DIV     APIC_OFFSET(0x3E0)
 > -
 > -#define APIC_DISABLE                0x10000
 > -#define APIC_EOI_ACK                0
 > -#define APIC_SELECT_TMR_PERIODIC    0x20000
 > -#define APIC_SPURIOUS_ENABLE        0x100
 > +#define PIT_CALIBRATE_DIVIDER       20
 > +#define PIT_CALIBRATE_TICKS       (PIT_FREQUENCY/PIT_CALIBRATE_DIVIDER)
 > +/* Since the PIT only has 2 one-byte registers, the maximum tick value is
 > + * limited to 16-bits. We can set the PIT to use a frequency divider if
 > + * needed. */

Multiline comments should have /* and */ on their own line.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/168#note_110604
You're receiving this email because of your account on gitlab.rtems.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240806/dbb6e47d/attachment.htm>