RTEMS | cpukit/libblock: Close all valid FDs (!186)

Joel Sherrill (@joel) gitlab at rtems.org
Mon Aug 12 18:00:21 UTC 2024



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/186 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on cpukit/libblock/src/bdpart-register.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/186#note_110885

 >     */
 >    free( logical_disk_name);
 > -  if (fd > 0) {

Add the coverity ids. This is what I had in the fix I thought I had a MR for. 

    Coverity CID 1467408 (original)

    Coverity CID XXX (followup)

    close() was called and fd can potentially be negative.
    Original patch was "> 0" but should have been ">= 0"




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/186
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240812/03f0076b/attachment.htm>


More information about the bugs mailing list