RTEMS | bsps/stm32h7: make errata configurable (!184)
Chris Johns (@chris)
gitlab at rtems.org
Fri Aug 16 01:20:29 UTC 2024
Chris Johns commented on a discussion on spec/build/bsps/arm/stm32h7/optenfmc282errata.yml: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/184#note_111137
> +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> +actions:
> +- get-boolean: null
> +- env-assign: null
> +- define-condition: null
Yes `enabled-by` is a well used expression however it can also be complex in how it can be used and the translation of that logic to the YAML format is not easy. I know from my recent PowerPC `libdebugger` experience I spent a number of hours guessing at the needed format to include specific BSPs and ended up adding a considerable number of prints to `wscript` to help. Then after all that I could see nothing wrong with the YAML fragment so deleted the bits I needed and typed them back in. It worked and to this day I have no idea what the difference was and why it worked after typing the same text back in.
We have a bespoke solution as a build system and to me this means we need to lead users with a specific example and updated documentation if their offering is not acceptable. I cannot help because I do not know enough to provide valid input and I feel I would only make things more confusing.
The change presented here is clever because it uses `waf` in a `waf` way and that implies to me some effort has been expended. We have a few choices:
1. Accept this change and move on
2. Help provided what you see as needed
3. Not accept the MR.
My choice is option 1 because I cannot help with 2 and do not accept option 3 as a valid option.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/184#note_111137
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240816/0d401ffb/attachment-0001.htm>
More information about the bugs
mailing list