RTEMS | x86_64/amd64: Add SMP support (!169)

[Joel Sherrill (@joel)]

Joel Sherrill commented on a discussion on bsps/x86_64/amd64/interrupts/isr_handler.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_111445

 >    movq rsp, SAVED_RSP
 >  
 >    /* Make space for CPU_Interrupt_frame */
 > -  subq $CPU_INTERRUPT_FRAME_SIZE, rsp
 > +  subq $CPU_INTERRUPT_FRAME_CALLER_SAVED_SIZE, rsp
 >  .set ALIGNMENT_MASK, ~(CPU_STACK_ALIGNMENT - 1)
 >    andq $ALIGNMENT_MASK, rsp
 >    // XXX: Save interrupt mask?

No. Someone was worried about saving the interrupt mask part of a register. Best to leave it until someone more confident than you or I sees it. 

Perhaps add an issue and cite it in the comment there. Resolve this comment with "resolve by issue" and be sure the comment references that issue.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_111445
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240823/fb6bd6d3/attachment-0001.htm>