RTEMS | x86_64: Add TLS support (!192)

Joel Sherrill (@joel) gitlab at rtems.org
Fri Aug 23 17:52:34 UTC 2024



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/192 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/apic.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/192#note_111450

 > +      if (lapic_count >= xAPIC_MAX_APIC_ID + 1 ||
 > +          lapic_get_id() == lapic_entry->Id)
 > +      {

This { should be at the end of the previous line.

--
  
Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/idt.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/192#note_111451

 > +
 > +#ifdef RTEMS_SMP
 > +rtems_status_code bsp_interrupt_get_affinity(

Is there any issue which could be cited in comments here to add interrupt affinity to this BSP?

Please resolve this "with issue" and cite the issue in a comment in the code.

--
  
Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/isr_handler.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/192#note_111452

 > + * Copyright (C) 2024 Matheus Pecoraro
 >   * Copyright (c) 2018.
 >   * Amaan Cheval <amaan.cheval at gmail.com>

Please pull Amaan's name onto the copyright line so these match. This may be necessary elsewhere also.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/192
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240823/6748b60e/attachment-0001.htm>


More information about the bugs mailing list