RTEMS | dev/serial: Refactor the pl011 driver to be extensible (!47)

[Kinsey Moore (@opticron)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47 was reviewed by Kinsey Moore

--
  
Kinsey Moore started a new discussion on bsps/aarch64/xilinx-versal/dev/serial/versal-uart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_111613

 > +
 > +  while (c-- > 0)
 > +    arm_pl011_write_polled(base, '\r');

You got the vast majority of them, but it looks like you missed this one.

--
  
Kinsey Moore started a new discussion on bsps/shared/dev/serial/arm-pl011.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_111614

 > +     * character to be lost. If txfifo is full, wait for it to be not full.
 > +     */
 > +    while (arm_pl011_is_txfifo_full(&regs->base));

This should use braces and a comment instead of ';' to indicate an intentional empty loop.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240828/d6d63948/attachment-0001.htm>