RTEMS | Draft: cpukit/posix/aio*: Implemented lio_listio() (!188)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111677

 > +#include <time.h>
 >  #ifdef HAVE_CONFIG_H
 >  #include "config.h"

Include of config.h should always be first.

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111678

 > +
 > +  /* Errors on parameters */
 > +  if ( list == NULL ) {

Make sure braces are consistently used

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111679

 > +      listcbp->lio_notification.sigp = sig;
 > +    }
 > +  }

Could the <span dir="">be bad</span>

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111680

 > +        req->listcbp = listcbp;
 > +        result = rtems_aio_enqueue( req );
 > +        if ( result != 0 ){

Space before brace

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111681

 > +        req->listcbp = listcbp;
 > +        result = rtems_aio_enqueue( req );
 > +        if ( result != 0 ){

Again

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/lio_listio.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111682

 > +      }
 > +    }
 > +  }

Again on the can of be a bad value

--
  
Joel Sherrill started a new discussion on testsuites/psxtests/psxaio05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188#note_111683

 > +  TEST_BEGIN();
 > +
 > +  for (int i = 0; i<4; i++ ) {

Break each test case info a subroutine. It helps readability




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/188
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240831/c2ca4be4/attachment-0001.htm>