RTEMS | Draft: Feature/stack reporter config (!86)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108880

 > +#define CONFIGURE_STACK_CHECKER_ENABLED
 > +#define CONFIGURE_STACK_CHECKER_REPORTER
 > +#define STACK_CHECKER_REPORTER_CUSTOM stackchk03_blown_stack_reporter

Lines 62 and 63 are odd. Configuring should be like this:

`#define CONFIGURE_STACK_CHECKER_REPORTER stackchk03_blown_stack_reporter`

There should not be a define named STACK_CHECKER_REPORTER_CUSTOM.

--
  
Joel Sherrill commented on a discussion on cpukit/include/rtems/stackchk.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108881

 > + * Application provided via <rtems/confdefs.h>
 > + */
 > +extern const Stack_checker_reporter_initialize _Stack_checker_reporter_initialize;

Line 254 (closing parenthesis) should be in column 1.

--
  
Joel Sherrill commented on a discussion on cpukit/include/rtems/stackchk.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108882

 > + * still valid or not.
 > + */
 > +typedef void (*Stack_checker_reporter_extension)(

Line 254 - ); should be in column 1.

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108883

 > +
 > +
 > +#include <rtems/stackchk.h>

No blank lines between these.

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108884

 > +
 > +/*
 > + * Copyright (C) 2024 On-Line Applications Research Corporation (OAR)

You should add yourself as a copyright.

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_108885

 > +
 > +    /* Allocate and initialize a Thread_Control structure */
 > +    Thread_Control test_thread;

Look at stackchk for rtems_task_create() and the file blow.c. Really create a task and let it blow the stack. In fact, if you put the rtems configuration in its own file in stackchk (keep what's there) and put your's from stackchk03 in its own file (w/custom handler), then you can adjust the yaml build spec file to share everything else from stackchk. If this isn't clear, chat me.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240708/ba6bd505/attachment-0001.htm>