RTEMS | Draft: Add new section: .debug_gdb_scripts, across all executables on RTEMS (!98)

[Christian Mauderer (@c-mauderer)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/98 was reviewed by Christian Mauderer

--
  
Christian Mauderer started a new discussion on bsps/mips/csb350/start/linkcmds: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/98#note_109039

 > +
 > +  /* Addition to let linker know about custom section for GDB pretty-printing support. */
 > +	.debug_gdb_scripts 0 : { *(.debug_gdb_scripts) }

For some reason you have a tab instead of two spaces here. You have that a few more times.

--
  
Christian Mauderer started a new discussion on cpukit/sapi/src/exinit.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/98#note_109040

 > +
 > +  /* Macro call to embed section in script for pretty-printing */
 > +  DEFINE_GDB_PY();

Is it necessary to have it inside of a function or could you place it outside of one? I'm not sure whether the `asm()` works outside of a function so please just tell me if it doesn't work.

If it works outside of a function, you might can remove the macro too and just add the `asm()` directly. Inside the function I like the solution because it does look quite clean.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/98
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240710/16dbee40/attachment-0001.htm>