RTEMS | Draft: cpukit/posix/aio*: Create notification at request completion (!118)

[Joel Sherrill (@joel)]

Joel Sherrill commented on a discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109543

 >  
 > +void rtems_aio_notify( struct sigevent *sig ) 
 > +{
 > +  #ifdef RTEMS_POSIX_API
 > +  int result;
 > +  if (sig == NULL) { return; }
 > +
 > +  switch ( sig->sigev_notify ) {
 > +
 > +    case SIGEV_SIGNAL:
 > +      result = sigqueue(
 > +        getpid(),
 > +        sig->sigev_signo,
 > +        sig->sigev_value
 > +      );
 > +      if ( result != 0 ){

Someone commented on the indentation of the cpp directives. They look off here also around line 366.

Also 368 should be formatted onto multiple lines. But if this is not something that could occur, it may be better to turn it into an rtems debug assert.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109543
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240718/bf721c08/attachment.htm>