RTEMS | Draft: cpukit/posix/aio*: Create notification at request completion (!118)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118 was reviewed by Joel Sherrill

--
  
Joel Sherrill commented on a discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109546

 > +        &thread,
 > +        attr,
 > +        (void * (*)(void *)) sig->sigev_notify_function,

The sigev_notify_function does not have the signature required for a pthread body. 

On line 454, you do not need the & to get the address of a function. The name of a function (or array) is itself an address.

--
  
Joel Sherrill commented on a discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109547

 >    }
 > +  rtems_aio_notify(
 > +    &(req->aiocbp->aio_sigevent)

I answered a question above in this thread. Resolve this thread when you read that.

--
  
Joel Sherrill commented on a discussion on testsuites/psxtests/psxaio04/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109548

 > +  rtems_test_assert( !status );
 > +  
 > +  fd = open( "/tmp/aio_fildes", O_RDWR|O_CREAT, S_IRWXU|S_IRWXG|S_IRWXO );

Watch for double blank lines. I see lines 79-80.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240718/34ff3d03/attachment-0001.htm>