RTEMS | Draft: cpukit/posix/aio*: Create notification at request completion (!118)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on cpukit/include/rtems/posix/aio_misc.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109594

 >  
 >  #ifdef RTEMS_DEBUG
 >  #include <assert.h>

I should have been clearer on assert. Do not use the C Library assert. Use the rtems debug assert _Assert(). This is only enabled when RTEMS is built with debug mode enabled. 

It is prototyped in <rtems/score/assert.h>

--
  
Joel Sherrill commented on a discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109595

 > +        sig->sigev_value
 > +      );
 > +      if ( result != 0 ){

Info should be in another comment but use _Assert() which is tied to the RTEMS Debug build configuration. rtems/score/assert.h should be the header.

--
  
Joel Sherrill commented on a discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109596

 > +
 > +      if ( sig->sigev_notify_function == NULL ){
 > +        //handle error

And any assert() should be the RTEMS internal _Assert().

--
  
Joel Sherrill commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109597


@opticron Please check that this is OK.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240719/15e693c6/attachment.htm>