RTEMS | dev/serial: Refactor the pl011 driver to be extensible (!47)

Ning Yang (@yangn0) gitlab at rtems.org
Fri Jul 19 16:29:29 UTC 2024




Ning Yang commented on a discussion on bsps/shared/dev/serial/arm-pl011.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109615

 > +   */
 > +  context->needs_sw_triggered_tx_irq = true;
 > +#endif
 > +  return true;
 > +}
 > +
 > +static bool arm_pl011_first_open(
 >    struct rtems_termios_tty *tty,
 >    rtems_termios_device_context *base,
 >    struct termios *term,
 >    rtems_libio_open_close_args_t *args
 >  )
 >  {
 > -  arm_pl011_context *ctx = (arm_pl011_context *) base;
 > +#ifndef BSP_CONSOLE_USE_INTERRUPTS
 > +  const

`#ifndef` is used here.

because the next line `context->tty = tty;` needs to modify tty and `const` cannot be used.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109615
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240719/64d52279/attachment.htm>


More information about the bugs mailing list