RTEMS | Draft: cpukit/posix/aio*: Create notification at request completion (!118)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on testsuites/psxtests/psxaio02/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109623

 > -      sprintf (filename, "/tmp/aio_fildes%d",i);
 > -      fd[i] = open (filename, O_RDWR|O_CREAT, S_IRWXU|S_IRWXG|S_IRWXO);
 > -      rtems_test_assert ( fd[i] != -1);

I still see " (" in the test on function calls.

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109624

 > +static void rtems_aio_notify( struct sigevent *sigp ) 
 > +{
 > +

Remove blank line.

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109625

 > +        sigp->sigev_value
 > +      );
 > +      _Assert( result == 0);

Unbalanced spaces inside parentheses. Remove space after (

--
  
Joel Sherrill started a new discussion on cpukit/posix/src/aio_misc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109626

 > + * @return void*
 > + */
 > +static void *rtems_aio_notify_funct_wrapper( void *args );

Just spell out function. You really are not saving much.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240719/f3a32996/attachment.htm>