RTEMS | dev/serial: Refactor the pl011 driver to be extensible (!47)

Ning Yang (@yangn0) gitlab at rtems.org
Fri Jul 19 18:28:13 UTC 2024




Ning Yang commented on a discussion on bsps/include/dev/serial/arm-pl011.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109641

 > +     * is not set. The interrupt is only set once the TXFIFO becomes empty
 > +     * after being filled to the trigger level. Until then, this flag variable
 > +     * ensures that the interrupt handler is software triggered.
 > +     */
 > +    bool needs_sw_triggered_tx_irq;
 > +
 > +    int tx_queued_chars;
 > +    rtems_termios_tty* tty;
 > +#endif
 >  } arm_pl011_context;
 >  
 > +#ifdef BSP_CONSOLE_USE_INTERRUPTS
 > +#define TXFIFO_IRQ_TRIGGER_LEVEL FIFO_LEVEL_ONE_EIGHTH
 > +#define RXFIFO_IRQ_TRIGGER_LEVEL FIFO_LEVEL_ONE_HALF
 > +
 > +enum fifo_trigger_level {

Is this a better way?

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_109641
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240719/9e952f97/attachment-0001.htm>


More information about the bugs mailing list