RTEMS | cpukit/posix/aio*: Create notification at request completion (!118)

[Kinsey Moore (@opticron)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118 was reviewed by Kinsey Moore

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109744

 > -  free (aiocbp);
 > +  free( (void*) aiocbp->aio_buf );
 > +  free(aiocbp );

The spacing around the parameter isn't correct.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio02/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109745

 >  
 > -  for (i=0; i<FD_COUNT; i++)
 > +  for( i=0; i<FD_COUNT; i++)

Formatting here as well.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio02/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109746

 > +        S_IRWXU|S_IRWXG|S_IRWXO 
 > +      );
 > +      rtems_test_assert(  fd[i] != -1 );

A double space.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio02/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109747

 > +  rtems_test_assert( status == AIO_CANCELED );
 > +
 > +  status = aio_cancel( fd[4],aiocbp[4] );

Formatting.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109748

 > -  status = rtems_aio_init ();
 > -  rtems_test_assert (status == 0);
 > +  status = rtems_aio_init(  );

Double space.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109749

 >  
 > -  for (i=0; i<FD_COUNT; i++)
 > +  for ( i=0; i<FD_COUNT; i++)

Formatting.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109750

 > +        S_IRWXU|S_IRWXG|S_IRWXO 
 > +      );
 > +      rtems_test_assert(  fd[i] != -1 );

Double space. I'm not sure if I got all the instances of formatting issues, so please go back and double check the remainder of the patch.

--
  
Kinsey Moore started a new discussion on testsuites/psxtests/psxaio03/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109751

 >  
 > -  puts (" Init: Open files ");
 > +  TEST_BEGIN( );

Usage of a space within empty parentheses is inconsistent in this patch.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240723/09acec05/attachment-0001.htm>