RTEMS | x86_64: Fix ISR handler macros (!71)
Matheus Pecoraro (@mpec)
gitlab at rtems.org
Tue Jun 25 17:15:15 UTC 2024
Matheus Pecoraro commented on a discussion on cpukit/score/cpu/x86_64/include/rtems/score/cpu.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/71#note_108066
> + } \
> }
>
> #define _CPU_ISR_Disable(_level) \
> { \
> - amd64_enable_interrupts(); \
> - _level = 1; \
> + _level = _CPU_ISR_Get_level(); \
> + amd64_disable_interrupts(); \
> (void) _level; /* Prevent -Wunused-but-set-variable */ \
> }
>
> #define _CPU_ISR_Flash(_level) \
> { \
> - amd64_enable_interrupts(); \
> + if(!_level) { \
Then I think the way it's currently done is fine for now. I just did the whitespace and syntax change Gedare had originally suggested.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/71#note_108066
You're receiving this email because of your account on gitlab.rtems.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240625/c3b83553/attachment.htm>
More information about the bugs
mailing list