RTEMS | Draft: cpukit: add support for common CAN/CAN FD stack (!49)

Pavel Pisa (@ppisa) gitlab at rtems.org
Fri Jun 28 11:36:07 UTC 2024




Pavel Pisa commented on a discussion on cpukit/dev/can/can-quekern.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/49#note_108455

 > +    edge = NULL;
 > +  } else {
 > +    edge = TAILQ_FIRST( &canque_dead_edges );
 > +    TAILQ_REMOVE( &canque_dead_edges, edge, inpeers );
 > +  }
 > +  rtems_mutex_unlock( &canque_dead_func_lock );
 > +  return edge;
 > +}
 > +
 > +rtems_task canque_dead_func( rtems_task_argument arg )
 > +{
 > +  struct canque_edge_t *qedge;
 > +  struct canque_ends_t *qends;
 > +  struct canque_ends_t *entry;
 > +
 > +  while ( 1 ) {

It is task in RTEMS waiting on semaphore and it is hard to move procession to clients because it could have latency time implications, this is low priority deferred processing, free can be blocking for too long. May it be name is incorrect, it has been initially modeled from Linux bottom half/tasklet handler so it should be probably canque_dead_func and shoudl be static or rtems added for namespace protection.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/49#note_108455
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240628/c3b775f8/attachment.htm>


More information about the bugs mailing list