RTEMS | Draft: cpukit: add support for common CAN/CAN FD stack (!49)

Pavel Pisa (@ppisa) gitlab at rtems.org
Fri Jun 28 11:48:15 UTC 2024




Pavel Pisa commented on a discussion on cpukit/dev/can/can-quekern.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/49#note_108457

 > +int canqueue_kern_initialize( void )
 > +{
 > +  rtems_id dead_func_id;
 > +
 > +  if ( can_test_and_set_bit( CAN_KERN_INITIALIZED, &kern_flags ) == 1 ) {
 > +    /* Already initialized */
 > +    return 0;
 > +  }
 > +
 > +  TAILQ_INIT( &canque_dead_ends );
 > +  TAILQ_INIT( &canque_dead_edges );
 > +
 > +  rtems_task_create(
 > +    rtems_build_name( 'C', 'A', 'N', 'D' ),
 > +    CAN_DEAD_FUNC_PRIORITY,
 > +    RTEMS_MINIMUM_STACK_SIZE+0x1000,

It should be analyzed, the 4k are too much but it has been sane reserve during development. Is there some check possible by GCC by call graph analysis? We should have no recursive function in the code so it could work at least as compile time test and fail if to small value is chosen.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/49#note_108457
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240628/a9734426/attachment.htm>


More information about the bugs mailing list