[RTEMS Project] #4862: score/ & bsps/: Unused input parameters

[RTEMS trac]

#4862: score/ & bsps/: Unused input parameters
---------------------------+------------------------------
 Reporter:  Daniel Páscoa  |       Owner:  Sebastian Huber
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  6.1
Component:  unspecified    |     Version:  6
 Severity:  normal         |  Resolution:
 Keywords:  qualification  |  Blocked By:
 Blocking:                 |
---------------------------+------------------------------
Description changed by Sebastian Huber:

Old description:

> The following functions list input parameters on their signature that
> seem not to be used:
>
> ||=**File** =||= **Function** =||= **Line** =||
> ||bsps\shared\cache\cacheimpl.h||smp_cache_inst_inv_all ||293||
> ||bsps\shared\dev\clock\clockimpl.h||void Clock_isr||130||
> ||bsps\shared\dev\clock\clockimpl.h||rtems_isr Clock_isr||134||
> ||bsps\shared\irq\irq-
> generic.c||bsp_interrupt_allocate_handler_index||62||
> ||bsps\sparc\leon3\start\bspclean.c||bsp_fatal_extension||70||
> ||cpukit\score\src\threadchangepriority.c||static void
> _Thread_Priority_action_change( ); ||92||
> ||cpukit\score\src\threadq.c||_Thread_queue_MP_callout_do_nothing||157||
> ||cpukit\score\src\threadqenqueue.c||_Thread_queue_Deadlock_fatal||382||
> ||cpukit\score\src\threadqops.c||_Thread_queue_FIFO_do_initialize||137||
> ||cpukit\score\src\threadqtimeout.c||_Thread_queue_Add_timeout_ticks||28||
> ||cpukit\score\src\threadrestart.c||_Thread_Join_flush_filter||84||
> ||cpukit\score\src\userextiterate.c||_User_extensions_Thread_begin_visitor||102||
>

> Could one please double-check if in each case the unused parameters can
> be safely removed from the function’s signature? PS: The first functions
> are also implemented within .h files and perhaps could be moved to .c
> files.
>
> **Additional Notes:**
> This ticket was raised as an outcome of the Independent SW Verification
> and Validation (ISVV) for ESA-promoted RTEMS SMP Qualification Data Packs
> (https://rtems-qual.io.esa.int). The original ISVV reference for this
> issue is RTEMS-SMP-CODE-VER-028.

New description:

 The following functions list input parameters on their signature that seem
 not to be used:

 ||=**File** =||= **Function** =||= **Line** =||= **Resolution** ||
 ||bsps\shared\cache\cacheimpl.h||smp_cache_inst_inv_all ||293||Unused due
 to API constraints||
 ||bsps\shared\dev\clock\clockimpl.h||void Clock_isr||130||Fixed: parameter
 can be used||
 ||bsps\shared\dev\clock\clockimpl.h||rtems_isr Clock_isr||134||Fixed:
 parameter can be used||
 ||bsps\shared\irq\irq-
 generic.c||bsp_interrupt_allocate_handler_index||62||Fixed: parameter
 removed||
 ||bsps\sparc\leon3\start\bspclean.c||bsp_fatal_extension||70||API backward
 compatibility||
 ||cpukit\score\src\threadchangepriority.c||static void
 _Thread_Priority_action_change( ); ||92||Unused due to API constraints||
 ||cpukit\score\src\threadq.c||_Thread_queue_MP_callout_do_nothing||157||Unused
 due to API constraints||
 ||cpukit\score\src\threadqenqueue.c||_Thread_queue_Deadlock_fatal||382||Unused
 due to API constraints||
 ||cpukit\score\src\threadqops.c||_Thread_queue_FIFO_do_initialize||137||Unused
 due to API constraints||
 ||cpukit\score\src\threadqtimeout.c||_Thread_queue_Add_timeout_ticks||28||Unused
 due to API constraints||
 ||cpukit\score\src\threadrestart.c||_Thread_Join_flush_filter||84||Unused
 due to API constraints||
 ||cpukit\score\src\userextiterate.c||_User_extensions_Thread_begin_visitor||102||Unused
 due to API constraints||


 Could one please double-check if in each case the unused parameters can be
 safely removed from the function’s signature? PS: The first functions are
 also implemented within .h files and perhaps could be moved to .c files.

 **Additional Notes:**
 This ticket was raised as an outcome of the Independent SW Verification
 and Validation (ISVV) for ESA-promoted RTEMS SMP Qualification Data Packs
 (https://rtems-qual.io.esa.int). The original ISVV reference for this
 issue is RTEMS-SMP-CODE-VER-028.

--

--
Ticket URL: <http://devel.rtems.org/ticket/4862#comment:8>
RTEMS Project <http://www.rtems.org/>
RTEMS Project