RTEMS | Arm PMSA improvements (!287)

[Sebastian Huber (@sebhub)]

Sebastian Huber started a new discussion on cpukit/score/cpu/arm/include/rtems/score/armv7-pmsa.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/287#note_114347

 > +  _Assert(index < _ARMV7_PMSA_Get_max_regions());
 > +
 > +  _ARMV7_Write_rgnr(ARMV7_RGNR_REGION(index));
 > +  _ARM_Instruction_synchronization_barrier();
 > +
 > +  return (_ARMV7_Read_drsr() & ARMV7_RSR_EN) != 0;
 > +}
 > +
 > +ARMV7_PMSA_TEXT_SECTION
 > +static inline uint32_t _ARMV7_PMSA_Find_available_region(void)
 > +{
 > +  uint32_t region_count = _ARMV7_PMSA_Get_max_regions();
 > +  uint32_t index;
 > +
 > +  for (index = 0; index < region_count; index++) {
 > +    if (_ARMV7_PMSA_Is_region_enabled(index) == false) {

This style is quite unusual in cpukit, I would change it to `if (!_ARMV7_PMSA_Is_region_enabled(index)) {`.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/287#note_114347
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20241104/98c5f4e0/attachment-0001.htm>